RecycleView角标越界问题分析

2022-06-07  本文已影响0人  馒Care

1、问题如下

java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid item position 19(offset:19).state:20 androidx.recyclerview.widget.RecyclerView{2a4d50e VFED..... .......D 0,0-1080,1979 #7f080160 app:id/rvNewsHome}, adapter:com.zj.architecture.mainscreen.TestNewsRvAdapter@fed2b2f, layout:androidx.recyclerview.widget.LinearLayoutManager@7de53c, context:com.zj.architecture.testrv.TestRvActivity@f4dbc62

2、模拟源码如下

package com.zj.architecture.testrv

import android.os.Bundle
import androidx.appcompat.app.AppCompatActivity
import com.zj.architecture.R
import com.zj.architecture.mainscreen.TestNewsRvAdapter
import com.zj.architecture.repository.NewsItem
import kotlinx.android.synthetic.main.activity_main.*
import kotlinx.coroutines.*

class TestRvActivity : AppCompatActivity() {
    private var dataItem = mutableListOf<NewsItem>()
    private val newsRvAdapter by lazy {
        TestNewsRvAdapter(
            {

            }, dataItem
        )
    }

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main_rv)
        fabStar.setOnClickListener {
            dataItem.removeAt(0)
            GlobalScope.launch {
                delay(3000)
                withContext(Dispatchers.Main) {

                    newsRvAdapter?.notifyItemRangeRemoved(0,dataItem.size)
                    newsRvAdapter?.notifyDataSetChanged()
                }
            }


        }
        newsRvAdapter.setHasStableIds(false)
        rvNewsHome.adapter = newsRvAdapter

        initData()
        srlNewsHome.setOnRefreshListener {
            initData()
            srlNewsHome.isRefreshing = false

        }
    }

    private fun initData() {
        dataItem.clear()
        for (i in 0 until 20) {
            var imageUrl = "https://t7.baidu.com/it/u=4162611394,4275913936&fm=193&f=GIF"
            if (i % 2 == 0) {
                imageUrl = "https://t7.baidu.com/it/u=1951548898,3927145&fm=193&f=GIF"
            }
            dataItem.add(NewsItem("title$i", "descriptioni$i", imageUrl))
        }
        rvNewsHome.adapter?.notifyDataSetChanged()
    }
}

3、问题拆解

class TestNewsRvAdapter(private val listener: (View) -> Unit, private var data: List<NewsItem>) :
    RecyclerView.Adapter<TestNewsRvAdapter.MyViewHolder>() {
    val TAG = "TestNewsRvAdapter"
    override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): MyViewHolder {
        Log.d(TAG, "onCreateViewHolder: ")
        return MyViewHolder(inflate(parent.context, R.layout.item_view, parent), listener)
    }

    override fun onBindViewHolder(holder: MyViewHolder, position: Int) {
        Log.d(TAG, "onBindViewHolder: ")
        holder.bind(data[position])
    }

    override fun getItemCount() = data.size

    override fun getItemId(position: Int): Long {
        return data[position].title.hashCode().toLong()
    }
    inner class MyViewHolder(override val containerView: View, listener: (View) -> Unit) :
        RecyclerView.ViewHolder(containerView),
        LayoutContainer {

        init {
            itemView.setOnClickListener(listener)
        }

        fun bind(newsItem: NewsItem) =
            with(itemView) {
                itemView.tag = newsItem
                tvTitle.text = newsItem.title
                tvDescription.text = newsItem.description
                ivThumbnail.load(newsItem.imageUrl) {
                    crossfade(true)
                    placeholder(R.mipmap.ic_launcher)
                }
            }
    }

}
if (holder == null) {
                final int offsetPosition = mAdapterHelper.findPositionOffset(position);
                if (offsetPosition < 0 || offsetPosition >= mAdapter.getItemCount()) {
                    throw new IndexOutOfBoundsException("Inconsistency detected. Invalid item "
                            + "position " + position + "(offset:" + offsetPosition + ")."
                            + "state:" + mState.getItemCount() + exceptionLabel());
                }

解决方案:

1、使用DiffUtils替代notify等操作,原理后续分析
2、对外部数据源操作后,要及时执行notify等操作。切勿类似demo中有延迟。很多业务其实都会忽略这一点,进行了很多耗时操作后,再执行notify操作。这个会导致内部部数据源不一致的角标越界崩溃
3、网上很多说法,自定义LinerLayoutManager,个人认为这个无效。可能因为执行顺序的原因吧。

@Override
    public void onLayoutChildren(RecyclerView.Recycler recycler, RecyclerView.State state) {
        try {
            super.onLayoutChildren(recycler, state);
        } catch (IndexOutOfBoundsException e) {
            e.printStackTrace();
        }
    }

4、网上还有很多说法,去除动画,其实,个人认为也没什么必要。角标越界,从源码分析来看,基本都是内外部数据源长度不一致导致的。动画的执行,耗时很短,类似我上面做的延迟。其实在这一点上,如果不是很花里胡哨的写了一堆动画,正常不用去掉

rvNewsHome.animation = null

5、以上4点我认为还有优化空间,基于旧业务,不太可能大改。所以,还在思考怎么处理更加合适。暂且先记录

上一篇 下一篇

猜你喜欢

热点阅读